Auto-update fts index

crates/pile-audio/src/common/vorbiscomment.rs

@@ -13,7 +13,7 @@ use crate::flac::blocks::{FlacMetablockDecode, FlacMetablockEncode, FlacPictureB
 use super::tagtype::TagType;
 
 #[derive(Debug)]
-#[allow(missing_docs)]
+#[expect(missing_docs)]
 pub enum VorbisCommentDecodeError {
 	/// We encountered an IoError while processing a block
 	IoError(std::io::Error),
@@ -74,7 +74,7 @@ impl From<FromUtf8Error> for VorbisCommentDecodeError {
 }
 
 #[derive(Debug)]
-#[allow(missing_docs)]
+#[expect(missing_docs)]
 pub enum VorbisCommentEncodeError {
 	/// We encountered an IoError while processing a block
 	IoError(std::io::Error),
@@ -132,39 +132,52 @@ impl VorbisComment {
 		let mut block = [0u8; 4];
 
 		let vendor = {
-			#[expect(clippy::map_err_ignore)]
 			d.read_exact(&mut block)
-				.map_err(|_| VorbisCommentDecodeError::MalformedData)?;
+				.map_err(|_err| VorbisCommentDecodeError::MalformedData)?;
 
 			let length = u32::from_le_bytes(block);
-			let mut text = vec![0u8; length.try_into().unwrap()];
 
-			#[expect(clippy::map_err_ignore)]
+			#[expect(clippy::expect_used)]
+			let mut text = vec![
+				0u8;
+				length
+					.try_into()
+					.expect("vendor length does not fit into usize")
+			];
+
 			d.read_exact(&mut text)
-				.map_err(|_| VorbisCommentDecodeError::MalformedData)?;
+				.map_err(|_err| VorbisCommentDecodeError::MalformedData)?;
 
 			String::from_utf8(text)?
 		};
 
-		#[expect(clippy::map_err_ignore)]
 		d.read_exact(&mut block)
-			.map_err(|_| VorbisCommentDecodeError::MalformedData)?;
-		let n_comments: usize = u32::from_le_bytes(block).try_into().unwrap();
+			.map_err(|_err| VorbisCommentDecodeError::MalformedData)?;
+
+		#[expect(clippy::expect_used)]
+		let n_comments: usize = u32::from_le_bytes(block)
+			.try_into()
+			.expect("comment count does not fit into usize");
 
 		let mut comments = Vec::new();
 		let mut pictures = Vec::new();
 		for _ in 0..n_comments {
 			let comment = {
-				#[expect(clippy::map_err_ignore)]
 				d.read_exact(&mut block)
-					.map_err(|_| VorbisCommentDecodeError::MalformedData)?;
+					.map_err(|_err| VorbisCommentDecodeError::MalformedData)?;
 
 				let length = u32::from_le_bytes(block);
-				let mut text = vec![0u8; length.try_into().unwrap()];
 
-				#[expect(clippy::map_err_ignore)]
+				#[expect(clippy::expect_used)]
+				let mut text = vec![
+					0u8;
+					length
+						.try_into()
+						.expect("comment length does not fit into usize")
+				];
+
 				d.read_exact(&mut text)
-					.map_err(|_| VorbisCommentDecodeError::MalformedData)?;
+					.map_err(|_err| VorbisCommentDecodeError::MalformedData)?;
 
 				String::from_utf8(text)?
 			};
@@ -218,9 +231,10 @@ impl VorbisComment {
 
 impl VorbisComment {
 	/// Get the number of bytes that `encode()` will write.
+	#[expect(clippy::expect_used)]
 	pub fn get_len(&self) -> u32 {
 		let mut sum: u32 = 0;
-		sum += u32::try_from(self.vendor.len()).unwrap() + 4;
+		sum += u32::try_from(self.vendor.len()).expect("vendor length does not fit into u32") + 4;
 		sum += 4;
 
 		for (tagtype, value) in &self.comments {
@@ -244,7 +258,8 @@ impl VorbisComment {
 			.to_uppercase();
 
 			let str = format!("{tagtype_str}={value}");
-			sum += 4 + u32::try_from(str.len()).unwrap();
+			sum +=
+				4 + u32::try_from(str.len()).expect("comment string length does not fit into u32");
 		}
 
 		for p in &self.pictures {
@@ -271,13 +286,18 @@ impl VorbisComment {
 	}
 
 	/// Try to encode this vorbis comment
+	#[expect(clippy::expect_used)]
 	pub fn encode(&self, target: &mut impl Write) -> Result<(), VorbisCommentEncodeError> {
-		target.write_all(&u32::try_from(self.vendor.len()).unwrap().to_le_bytes())?;
+		target.write_all(
+			&u32::try_from(self.vendor.len())
+				.expect("vendor length does not fit into u32")
+				.to_le_bytes(),
+		)?;
 		target.write_all(self.vendor.as_bytes())?;
 
 		target.write_all(
 			&u32::try_from(self.comments.len() + self.pictures.len())
-				.unwrap()
+				.expect("total comment count does not fit into u32")
 				.to_le_bytes(),
 		)?;
 
@@ -302,7 +322,11 @@ impl VorbisComment {
 			.to_uppercase();
 
 			let str = format!("{tagtype_str}={value}");
-			target.write_all(&u32::try_from(str.len()).unwrap().to_le_bytes())?;
+			target.write_all(
+				&u32::try_from(str.len())
+					.expect("comment string length does not fit into u32")
+					.to_le_bytes(),
+			)?;
 			target.write_all(str.as_bytes())?;
 		}
 
@@ -318,7 +342,11 @@ impl VorbisComment {
 				&base64::prelude::BASE64_STANDARD.encode(&pic_data)
 			);
 
-			target.write_all(&u32::try_from(pic_string.len()).unwrap().to_le_bytes())?;
+			target.write_all(
+				&u32::try_from(pic_string.len())
+					.expect("picture string length does not fit into u32")
+					.to_le_bytes(),
+			)?;
 			target.write_all(pic_string.as_bytes())?;
 		}