From 4c8a916085504c30314b3847212a9b4c798ac07e Mon Sep 17 00:00:00 2001
From: Mark <mark@betalupi.com>
Date: Thu, 23 Mar 2023 14:53:27 -0700
Subject: [PATCH] Added recursive parsing Improved error handling

---
 src/parser/treeify.rs | 34 +++++++++++++++++++++++++++++-----
 1 file changed, 29 insertions(+), 5 deletions(-)

diff --git a/src/parser/treeify.rs b/src/parser/treeify.rs
index 69fdbdf..8b8241f 100644
--- a/src/parser/treeify.rs
+++ b/src/parser/treeify.rs
@@ -39,11 +39,20 @@ fn treeify_binary(
 ) -> Result<usize, (LineLocation, ParserError)> {
 
 	let this: &Token = &g_inner[i];
+
+	if i == 0 {
+		// This binary operator is at the end of an expression.
+		let l = match this {
+			Token::PreOperator(l, _) => l,
+			_ => panic!()
+		};
+		return Err((*l, ParserError::Syntax));
+	}
+
 	let right: &Token = {
 		if i < g_inner.len()-1 {
 			&g_inner[i+1]
 		} else {
-			// This binary operator is at the end of the expression.
 			let l = match this {
 				Token::PreOperator(l, _) => l,
 				_ => panic!()
@@ -102,9 +111,11 @@ fn treeify_binary(
 
 		if right_val.is_none() || this_val > right_val.unwrap() {
 			// This operator has higher precedence, it takes both arguments
-			let left = g_inner.remove(i-1).unwrap();
+			let mut left = g_inner.remove(i-1).unwrap();
 			let this = g_inner.remove(i-1).unwrap();
-			let right = g_inner.remove(i-1).unwrap();
+			let mut right = g_inner.remove(i-1).unwrap();
+			if let Token::PreGroup(_, _) = right { treeify(&mut right)?; }
+			if let Token::PreGroup(_, _) = left { treeify(&mut left)?; }
 
 			let k = match this {
 				Token::PreOperator(_, k) => k,
@@ -197,7 +208,8 @@ fn treeify_unaryleft(
 
 		if right_val.is_none() || this_val > right_val.unwrap() {
 			let this = g_inner.remove(i).unwrap();
-			let right = g_inner.remove(i).unwrap();
+			let mut right = g_inner.remove(i).unwrap();
+			if let Token::PreGroup(_, _) = right { treeify(&mut right)?; }
 
 			let k = match this {
 				Token::PreOperator(_, k) => k,
@@ -296,7 +308,8 @@ fn treeify_unaryright(
 
 		if left_val.is_none() || this_val > left_val.unwrap() {
 			let this = g_inner.remove(i).unwrap();
-			let left = g_inner.remove(i-1).unwrap();
+			let mut left = g_inner.remove(i-1).unwrap();
+			if let Token::PreGroup(_, _) = left { treeify(&mut left)?; }
 
 			let k = match this {
 				Token::PreOperator(_, k) => k,
@@ -355,5 +368,16 @@ pub fn treeify(
 		};
 	}
 
+	*g = g_inner.pop_front().unwrap();
+
+	// Catch the edge case where the entire group we're given
+	// consists of one operator. This is always a syntax error.
+	match g {
+		Token::PreOperator(l, _) => {
+			return Err((*l, ParserError::Syntax));
+		},
+		_ => {}
+	};
+
 	return Ok(());
 }
\ No newline at end of file